Android support and interface additions

britzl / extension-imgui

Dear ImGUI extension for Defold

MIT License

51 stars 17 forks source link

Android support and interface additions #7

Closed dlannan closed 3 years ago

dlannan commented 3 years ago

Changes:

Added a working build for android (GLES2 - can probably use GLES3)
Added API methods for plot_lines, plot_histogram, text_colored and input_int4
Added examples for the above API changes.

britzl commented 3 years ago

The PR doesn't build and run on macOS:

/imgui/src/imgui/imgui_impl_metal.mm
    Line 544: cannot create __weak reference in file using manual reference counting
    __weak id weakSelf = self;

dlannan commented 3 years ago

Sorry commented using my work account. I'll remove the OSX/Mac files tonight. And once I have them working, I'll submit another PR.

britzl commented 3 years ago

Great. Please note that the extension already works on macOS though (using the opengl implementation)! I haven't looked into what might be required for it to work on iOS as well.

dlannan commented 3 years ago

Oh. Im a nugget - yes, I saw you had OSX support. I was thinking of moving it to metal so that IOS could potentially be supported as well. Didnt mean to break existing functionality. Sorry. Will remove those changes.

dlannan commented 3 years ago

Just a question. Should there be an OSX defined check here? https://github.com/britzl/extension-imgui/blob/97e29160b63d5a62394f44ffa25ce4d0d77625c2/imgui/src/imgui/imconfig.h#L1-L10

britzl commented 3 years ago

Should there be an OSX defined check here?

It is my understanding that there is no need to specify a GL loader on OSX (at least not when using Dear ImGUI from Defold). So for OSX we fallback to the empty dummy loader.

dlannan commented 3 years ago

Ok. Probably has the binding in the staticlibs that are compiled with the build. Thats good to know. Thanks.