search

brix / crypto-js

JavaScript library of crypto standards.
Other
15.88k stars 2.39k forks source link

feat: add urlsafe #357

Closed spencer17x closed 3 years ago

spencer17x commented 3 years ago

issue：https://github.com/brix/crypto-js/issues/252

kylelieTomo commented 3 years ago

and this update makes crypto doesn't work on ie11

spencer17x commented 3 years ago

Are you sure it is affected by this pr? Can you provide some information? If it is determined that it is affected by pr, you can delete this method if you don't need url-safe. @kylelieTomo

kylelieTomo commented 3 years ago

yes, ie11 doesn't support default value on params. and the "urlSafe=true" affect ie

spencer17x commented 3 years ago

Maybe this repo does not configure the corresponding babel, you can clone in the past and configure the corresponding babel yourself

trmpowell commented 3 years ago

@kylelieTomo, were you able to get this working in IE 11?

kylelieTomo commented 3 years ago

@kylelieTomo, were you able to get this working in IE 11?

no, i just fall back to 4.0.0

trmpowell commented 3 years ago

@Spencer17x, do you have any plans to resolve this? Permanently falling back to an old version isn't ideal as consumers wouldn't be able to get new security fixes in future versions.

spencer17x commented 3 years ago

@trmpowell The author of this library is not me. If I fix it, I need to mention pr. I am not sure when the author will merge. If you need it, I can fork it and maintain it.

spencer17x commented 3 years ago

@trmpowell Hello, I used this pr to fix the problem you raised, but I need to wait for the author to merge, and I may fork this repo and use other build tools to maintain it in the future.

trmpowell commented 3 years ago

Thanks, @Spencer17x! No problem on needing to wait for the repo owner to merge. That is expected. 😃

Mehmdsed commented 10 months ago

Android

Mehmdsed commented 10 months ago

Wifi