search

brix / crypto-js

JavaScript library of crypto standards.
Other
15.89k stars 2.39k forks source link

avoid bundling node crypto in browser #359

Closed hkjpotato closed 3 years ago

hkjpotato commented 3 years ago

Fixed #276

I just follow the fix on the similar issue found in decimal.js. https://github.com/MikeMcl/decimal.js/pull/42

However, crypto-js should probably consider removing require at all. https://github.com/MikeMcl/decimal.js/pull/42#issuecomment-259472652

hkjpotato commented 3 years ago

@evanvosberg can you help review this tiny PR, thank you

hkjpotato commented 3 years ago

close it because there is a better solution following the spec https://github.com/brix/crypto-js/pull/364