brmather
commented
5 years ago Hi Jesse,
Thank you for your contributions to pycurious, I have merged your pull request into the master branch and once all reviews have been received I will bump the software package version to 1.0. The contribution guidelines have been updated in 28f66c6505350986775103c06403321c4677faf4 to make clear that while we welcome all contributions great and small, there are some specific areas that we would like to encourage development. These include:
- Implementing different taper functions in addition to built-in numpy functions (e.g.
numpy.hanning,numpy.hanning) - Enhancing I/O capabilities (e.g. exporting to netCDF, HDF5 formats)
- Expanding the Jupyter notebook examples for specific use cases and study areas.
Many thanks for your review. I'm pleased you found the repository in good shape. Please raise an issue if you notice something else you would like to see addressed.
Best regards, Ben
jessepisel
Howdy Ben,
I had a few minor edits for the JOSS review. The first edit was a typo in paper.md. The second was in the power spectrum example 1. The third was reformatting the docstring for
radial_spectrum_log. Other than those it looks pretty good!My only other comment would be to add a section in CONTRIBUTING.md that covers what to do for those seeking support on
pycurious. I think once you have added that, it should be good to go! It was really fun going through the package and the documentation, I think that it is all very clear and it is a well written package. Let me know if you have any questions on my changes.