search

brmather / pycurious

Python package for computing the Curie depth from the magnetic anomaly
https://brmather.github.io/pycurious/
GNU Lesser General Public License v3.0
38 stars 17 forks source link

[REVIEW] Fix wrong error propagation #22

Closed santisoler closed 5 years ago

santisoler commented 5 years ago

Part of https://github.com/openjournals/joss-reviews/issues/1544.

When computing the error for the depth to the bottom of the magnetic source, the errors of Zor and Ztr should be added instead of subtracted: https://github.com/brmather/pycurious/blob/759fc520c22503f0b40b6a63faa4e632dd9f1e88/pycurious/grid.py#L666

 dZb = 2.0*dZor + dZtr
rdelhaye commented 5 years ago

Completely correct, the calculation has been amended in commit cb8d2fd. Thank you!