brmodeloweb / brmodelo-app

BRMW is a free open source entity-relationship database modeling tool. We're working to make learning database modeling simple and accessible for everyone.
https://www.brmodeloweb.com
Apache License 2.0
1.01k stars 47 forks source link

feature/multi-element-action #467

Closed miltonbsn closed 11 months ago

miltonbsn commented 1 year ago

Summary

Copy and paste allowed only on conceptual module.

Logic relations have deep internal connections (AKA foreign key), to copy and paste elements we have to update all these references and although not impossible, it is very complex and could lead to bugs.

In order to inform users about this limitation, the following message is now visible when users try to copy + paste elements in a logic model

image

Unrelated fixes

Close #456 Close #473

idmarjr commented 1 year ago

Éx um monxtro!

I did some tests here and it's working smoothly.
Do you want to go above and beyond?

  1. Once only one element is selected, show the selection mark too (The one with green border)
  2. Allow user to select multiple elements one-by-one when holding cmd / ctrl and clicking in each element.
miltonbsn commented 11 months ago

Éx um monxtro!

I did some tests here and it's working smoothly. Do you want to go above and beyond?

  1. Once only one element is selected, show the selection mark too (The one with green border)
  2. Allow user to select multiple elements one-by-one when holding cmd / ctrl and clicking in each element.

1) could not do it because the actions conflict 2) I tried but did not work after spending good amount of time. Will try more but wont hold the PR

idmarjr commented 11 months ago

@miltonbsn regarding the limitation to copy + paste in Logic models, I have the following question:

Considering Foreign key as the limitation factor, can we enable c+p if a table still don't have stablished relationships yet?
Meaning, should we enable user co c+p tables that dont have a connection with any other table?

idmarjr commented 11 months ago

On more thing...
Is this branch mixing two different fixes?

Branch name is feature/validate-mail and I also see some changes related to that... 😓

miltonbsn commented 11 months ago

@miltonbsn regarding the limitation to copy + paste in Logic models, I have the following question:

Considering Foreign key as the limitation factor, can we enable c+p if a table still don't have stablished relationships yet? Meaning, should we enable user co c+p tables that dont have a connection with any other table?

Yesss, I was a bit lazy but will do it :sweat_smile:

miltonbsn commented 11 months ago

On more thing... Is this branch mixing two different fixes?

Branch name is feature/validate-mail and I also see some changes related to that... 😓

Yes, I started doing one thing and had this idea and delivered two. Sorry and forgive me this time :pray:

idmarjr commented 11 months ago

Yes, I started doing one thing and had this idea and delivered two. Sorry and forgive me this time 🙏

judjing-you

miltonbsn commented 11 months ago

@idmarjr we are good to go again. I did a mistake when updating this branch but i will fix when merging this PR.

miltonbsn commented 11 months ago

@idmarjr wait, it is worst than I expected, i will open another PR