search

brmson / dataset-sts

Semantic Text Similarity Dataset Hub
715 stars 206 forks source link

Adding skip-thoughts model #29

Open nadvornix opened 8 years ago

nadvornix commented 8 years ago
pasky commented 8 years ago

Brilliant, I'm super-glad that we have this PR here now. :)

However, I think in order to merge this in a maintainable form, we should discuss what the motivation is behind not using standard ptscorers but rather a custom compiled model. Can you please expand on that? What would happen if we used the standard ptscorer with absdiff merge_mode? I'm afraid that this way, the code will really go quickly out of date and break, as you note in the xxx comment, so I'm trying to gauge the level of effort required to offload this back to ptscorer.

pasky commented 8 years ago

Jirka, just a soft ping if you'd find a few moments to take a look. :)

nadvornix commented 8 years ago

Hi. I am sorry but I am rather busy over summer. I think I will not be able to find time to do this.