Fixing squid:S2131, Fixing squid:S2184

brmson / yodaqa

A Question Answering system built on top of the Apache UIMA framework.

http://ailao.eu/yodaqa

Other

619 stars 205 forks source link

Fixing squid:S2131, Fixing squid:S2184 #32

Closed misgersameer closed 8 years ago

misgersameer commented 8 years ago

This pull request is focused on resolving occurrences of Sonar rule " squid:S2131 - Primitives should not be boxed just for "String" conversion, squid:S2184 - Math operands should be cast before assignment". You can find more information about the issues here: https://dev.eclipse.org/sonar/rules/show/squid:S2131 https://dev.eclipse.org/sonar/rules/show/squid:S2184

Please let me know if you have any questions. Sameer Misger

pasky commented 8 years ago

It'd be great if you could put the short text explanations of the squid issues to the commit message, like in your other commit. Nevertheless, thank you very much, that's a good catch with the typecasts!