Fixing squid:S1197- Array designators "[]" should be on the type, not the variable

brmson / yodaqa

A Question Answering system built on top of the Apache UIMA framework.

http://ailao.eu/yodaqa

Other

619 stars 205 forks source link

Fixing squid:S1197- Array designators "[]" should be on the type, not the variable #35

Closed misgersameer closed 8 years ago

misgersameer commented 8 years ago

This pull request is focused on resolving occurrences of Sonar rule "squid:S1197- Array designators "[]" should be on the type, not the variable". You can find more information about the issues here: https://dev.eclipse.org/sonar/rules/show/squid:S1197

Please let me know if you have any questions. Sameer Misger

pasky commented 8 years ago

Thank you for the pull request, but this is one that I'm not really fond of.

To me, both seem equally readable (my personal preference is the other way because I have a C background), so I dispute this is a gain, and the diff is really big and bound to create bunch of conflicts with our dev branches.

"Looking at both the type and variable", well, they are right next to each other and the [] is pretty obviously visible.