search

brndd / vanilla-tweaks

Custom QoL patches to the 1.12.1 WoW client
MIT License
162 stars 25 forks source link

Add mouse camera jump fix. #18

Closed phamd closed 1 year ago

phamd commented 1 year ago

Offsets and bytes taken from https://github.com/brndd/vanilla-tweaks/issues/17 For reference, I used: Vanilla.txt, Turtle WoW Camera Patch.exe, and Vanilla Camera Patch.exe. Tested on Turtle WoW. I can make further changes if needed.

brndd commented 1 year ago

Thanks for this!

I saw this fix when the issue was made, but haven't had the time to test it out yet -- and I'm not sure if I could easily do that anyway, because I don't think I've noticed the cursor jumping problem very often on Wine. In any case, I'll give your patch a try soon.

Have you played with this, and if so, have you noticed any side effects?

phamd commented 1 year ago

Without the patch, every 3 right clicks would send my mouse to the center of the screen (with Hardware Cursor enabled). So the fix is definitely working and I haven't encountered any side effects yet.

I also just set up VanillaFixes + nampower and it feels good so far.

brndd commented 1 year ago

OK. I tested it out myself but couldn't notice a difference one way or the other -- I suppose this bug just doesn't happen when playing on Linux using Wine. I remember it being very annoying on Windows though, so it's nice to see it fixed.

I decided to call it "camera skip glitch fix" since I felt that's maybe a bit more descriptive.

Thanks again for the PR.