brndd / vanilla-tweaks

Custom QoL patches to the 1.12.1 WoW client
MIT License
163 stars 26 forks source link

Could this be outfitted for a 2.4.3 client? #21

Open cpevors opened 1 year ago

cpevors commented 1 year ago

I have adored this project for my 1.12.1 client for a good while, but I've moved on to a TBC client now. Would it be monumentally challenging to reconfigure this (most specifically the groundeffectdist and the farclip and the LAA) to work with a 2.4.3 client?

I'd be willing to pay for your time and skills.

brndd commented 1 year ago

It shouldn't be too difficult. A lot of the necessary offsets can already be found on Ownedcore and other such sources, and the rest shouldn't be too difficult to find since the TBC client is still quite similar to the vanilla client. Also, I believe many of these features are already adjustable in TBC to begin with -- I feel like frilldistance is one such thing? They might have hardcoded max values that could do with increasing, though.

No promises on when or if I can get around to doing any of that, though -- real life has kept me sufficiently exhausted to have little desire to work on hobby projects recently, and I am not super interested in TBC personally. I have been dreaming of reimplementing this patcher as a drop-in DLL hack to make it a little easier to use, so adding support for TBC might be part of that, if I ever get around to it.

cpevors commented 1 year ago

Thank you for the reply, and while I’ve been able to find, as you mentioned, some adjustments on Ownedcore, re: LAA, FOV, etc., the one that most annoyingly eludes me is a groundeffectdist patch. TBC has a hard-coded maximum of 140, and even something like 300 would make the game look less awkward. (At 140 distance and 256 density, the foliage has a very hard edge where the foliage just falls off entirely, and they pop into view as you ambulate. It’s hideous, heh.)

But I fully appreciate that life can be and often is exhausting and time-consuming enough, so I understand completely. I appreciate your reply, and if you do ever get around to putzing with it and making it usable on TBC 2.4.3 clients, do let me know. I’d happily toss some funds and a six pack your way.

andrewmunro commented 1 year ago

👍 for this. I've been looking for something that fixes the camera skip glitch in the TBC 243 client.

andrewmunro commented 1 year ago

👍 for this. I've been looking for something that fixes the camera skip glitch in the TBC 243 client.

Ah for anyone looking for a workaround, I found the patched EXEs for each client in the mega link on https://github.com/brndd/vanilla-tweaks/issues/17

WOWER-star commented 1 year ago

Hello, I am currently using the 335 version of the client, there is the same problem, can I use this program to solve the problem? -- My English is not so good that I can't express my gratitude to you. I hope you don't mind.

cpevors commented 1 month ago

It shouldn't be too difficult. A lot of the necessary offsets can already be found on Ownedcore and other such sources, and the rest shouldn't be too difficult to find since the TBC client is still quite similar to the vanilla client. Also, I believe many of these features are already adjustable in TBC to begin with -- I feel like frilldistance is one such thing? They might have hardcoded max values that could do with increasing, though.

No promises on when or if I can get around to doing any of that, though -- real life has kept me sufficiently exhausted to have little desire to work on hobby projects recently, and I am not super interested in TBC personally. I have been dreaming of reimplementing this patcher as a drop-in DLL hack to make it a little easier to use, so adding support for TBC might be part of that, if I ever get around to it.

Just a kind nudge to gauge any interest in looking into this further. Totally understand that TBC isn't something you're overly keen on, and that life may be busy. I tried my hand at reverse-engineering the values myself, and I've hit a bit of a wall. Would happily pay for time and effort, if ever you were interested.

Appreciate this project and all you've offered to the private server community, heaps. Thanks!