search

brndd / vanilla-tweaks

Custom QoL patches to the 1.12.1 WoW client
MIT License
152 stars 24 forks source link

It is not clear that tweaking a previously tweaked .exe doesn't let you undo tweaks #28

Open Zebouski opened 11 months ago

Zebouski commented 11 months ago

When supporting users of VT, i've had this crop of a few times, where people will tweak an exe once, then realize oh wait i don't want FOV or I don't want autoloot, and so they go to retweak it, they see that correctly the patch they are skipping isn't applied, and then get really confused when their game still has the patch applied.

We could: A: Write a disclaimer in the readme saying "Make sure to only ever tweak the unaltered copy of your WoW.exe" B: Add terminal output saying something like "Warning: Passed --no-sound-in-background, but found that the patch has previously been applied! Try tweaking an unmodified copy of WoW.exe"

Or: C: Allow for when people pass the --no-* arguments, for VT to un-tweak the values and patch in the default values. Not sure if this is possible.

brndd commented 11 months ago

A mechanism to remove the tweaks would be pretty easy to implement. Would just have to grab the default values and code them in.

Honestly this thing has probably gotten more popular than a quick and dirty command line app that was originally just meant for personal usage has any right to be. I've been wanting to rewrite it as a drop-in DLL mod for a long time (that way the options could be in a config file which should be easier for users), but haven't found the time or motivation to do so yet.