brndd / vanilla-tweaks

Custom QoL patches to the 1.12.1 WoW client
MIT License
163 stars 26 forks source link

FPS & CTM Limitation #5

Open SSDDX-Devs opened 2 years ago

SSDDX-Devs commented 2 years ago

Hello Sir Thanks for the Max Camera Distance Patch There is one more serious limitation of this 1.12.1 client If you limit your WoW.exe with 60fps its works fines but if you remove fps limit CTM (Click To Move) feature stop working https://user-images.githubusercontent.com/19153689/183430278-e3b998be-6b87-4d4d-b17d-f4035c378735.mp4

Update : Found the address for fps limit in ctm logic now there is only one thing left to solve, after increasing fps above 120 character u-turn bugs out in the video below 1st i showed how character u-turn normally without changing anything then i increased fps to 100 and ctm stops working then i patched memory(0x610D84) for fix (2 ways to fix this either increase fps from 65 to max 127 or force skip 2 instructions by changing jne to jmp) and at 100fps ctm starts working then i increased more fps now ctm works but when we try to u-turn it bugs....

https://youtu.be/5eH8UWrY1fY

brndd commented 2 years ago

I haven't looked into this properly, but it looks like a potentially quite difficult thing to fix. I've never used click-to-move so I don't have any intuitive idea about how it could work either.

I don't have time to look into this right now, and probably won't in the near future either, but I'll leave the issue open in case anyone wants to contribute or if I get the opportunity to investigate later.