brndnmtthws / conky

Light-weight system monitor for X, Wayland (sort of), and other things, too
https://conky.cc
GNU General Public License v3.0
6.94k stars 608 forks source link

Remove dpi scaling of maximum width #1877

Closed Caellian closed 1 month ago

Caellian commented 1 month ago

This PR removes dpi_scaleing of maximum width setting.

This seems incorrect because I expect maximum width to use absolute pixel value, otherwise meaning of maximum_width setting changes with DPI:

image NOTE: Height difference is caused by font height, conky height can't be limited.

This fixes #1528.

This PR also fixes a regression introduced in #1841, where I incorrectly assumed templated base class function would be overriden by display outputs so DPI scaling was completely disabled.

Other changes

This PR also:

Testing

netlify[bot] commented 1 month ago

Deploy Preview for conkyweb canceled.

Name Link
Latest commit 6d194af914d4ca03d26131dcc03a78b615d413f0
Latest deploy log https://app.netlify.com/sites/conkyweb/deploys/66314effc9a3a600082b3523