brndnmtthws / conky

Light-weight system monitor for X, Wayland (sort of), and other things, too
https://conky.cc
GNU General Public License v3.0
6.97k stars 610 forks source link

Disable Vc_ENABLE_INSTALL by default #1909

Closed Vincent-C closed 1 month ago

Vincent-C commented 1 month ago

Checklist

Description

Debian maintainer here, forwarded from Debian BTS #1071006

By default, the newly vendored Vc library will be installed alongside conky itself, e.g. all of the headers and the cmake files that ship with Vc. This is unnecessary and even undesired if the user already had Vc installed from other sources, e.g. libvc-dev in Debian/Ubuntu. I can turn this off with -DVc_ENABLE_INSTALL=OFF but I think this would be a sane default option.

netlify[bot] commented 1 month ago

Deploy Preview for conkyweb canceled.

Name Link
Latest commit 0e80a30e4f04c02b6a9c68f2e9b3a6e6e79d1033
Latest deploy log https://app.netlify.com/sites/conkyweb/deploys/6641f651a26d990008bbebca
Caellian commented 1 month ago

I believe I should've commented out the installation part of Vc CMake while adding it:

Caellian commented 1 month ago

@Vincent-C let's wait for @brndnmtthws to approve before merging, but I'm pretty sure removing the whole installation part is fine.