[Bug]: Version 1.21.1 Images larger

[ACR-Jeff]

What happened?

I am on Void Linux, I updated to version 1.21.1, What I have here is a popup calendar, Images were perfect prior to the update, Images are now larger then their original size or specified given size. If I have an image as 1 pixel in diameter it is very noticeable the size difference, If I have an image as a custom Horizontal bar at 1 pixel height, It is always larger. Code sample: ${image ~/.config/conky/conky-i3/images/H-Line-green.png -p 29,55 -s 225x1} This should result in the image being only 255x1 pixel in height, Yet it results in a larger image, Which causes the conky to be all out of line, I am only noticing the 1 pixel because it's so obvious.

Version

1.21.1

Which OS/distro are you seeing the problem on?

Linux (other)

Conky config

conky.config = {

-- -----------------------------------------
--             Windows Settings           --
-- -----------------------------------------
    own_window = true,
    own_window_type = 'normal',
    own_window_class = 'conky-calendar-i3',
    own_window_transparent = false,
    own_window_hints = 'undecorated,sticky,below,skip_taskbar,skip_pager',
    own_window_argb_visual = true,
    own_window_argb_value = 255,
    own_window_colour = '2e2e2e',

    double_buffer = true,
    --_buffers = true,
    background = true,
    format_human_readable = true,

-- -----------------------------------------
--             Possition & Size           --
-- -----------------------------------------
    alignment = 'bottom_left',

    minimum_width = 282, 
    maximum_width = 282,
    minimum_height = 275,
    --maximum_height = 180,
        gap_x = 11,
    gap_y = -275,

-- -----------------------------------------
--                  Font                  --
-- -----------------------------------------
    use_xft = true,
    xftalpha = 0,
    override_utf8_locale = true,
    text_buffer_size = 2048,

-- -----------------------------------------
--             Border & Margin            --
-- -----------------------------------------
    draw_borders = false,
    draw_outline = false,
    draw_shades = false,
    draw_graph_borders = false,
    border_inner_margin = 0,
    border_outer_margin = 20,

-- -----------------------------------------
--                 Colors                 --
-- -----------------------------------------
    default_color = 'DCDCDC',
    color0 = '19ae38',
    color1 = 'DDDDDD',
    color2 = 'AAAAAA',
    color3 = '888888',
    color4 = '2679a5',
    color5 = '222222',

-- -----------------------------------------
--                Interval                --
-- -----------------------------------------
    update_interval = 1,

};

conky.text = [[
${image ~/.config/conky/conky-i3/images/H-Line-Lightgray.png -p 1,-1 -s 280x9}
${image ~/.config/conky/conky-i3/images/vline-darkgray.png -p 2,0 -s 2x275}
${image ~/.config/conky/conky-i3/images/V-Line-Lightgray.png -p 1,0 -s 6x275}
${image ~/.config/conky/conky-i3/images/vline-darkgray.png -p 281,0 -s 1x275}
${image ~/.config/conky/conky-i3/images/V-Line-Lightgray.png -p 275,0 -s 6x275}

${GOTO 100}${voffset -115}${font FiraCode Nerd:size=14}${time %I:%M %p}${font}
${image ~/.config/conky/conky-i3/images/H-Line-green.png -p 29,55 -s 225x1}
${voffset 5}${color1}${font FiraMono Nerd Font:size=14}${execpi 100 ~/.config/conky/conky-i3/calendar/cal.lua}

${image ~/.config/conky/conky-i3/images/H-Line-darkgray.png -p 0,0 -s 300x1}
${image ~/.config/conky/conky-i3/images/H-Line-Lightgray.png -p 1,266 -s 280x7}
${image ~/.config/conky/conky-i3/images/H-Line-darkgray.png -p -10,274 -s 300x2}

]];

Stack trace

No response

Relevant log output

No response

[ACR-Jeff]

I am not much of a coder, Yet I know a few things, This looks like an issue here that maybe causing this? XCreatePixmap(display, window.window, window.geometry.width() + 1, window.geometry.height() + 1, https://github.com/brndnmtthws/conky/compare/v1.21.1...main#diff-dc0e1a99e9a1c2c6d78ae6fc36bd394529ca076fc1ead87e81d23ed493edb540

[Caellian]

Related to #1930, #1925

[ACR-Jeff]

Related to #1930, #1925

Thank you for replying, I am not sure what this means, I read the following issues, Yet unsure if I have to modify my conky to fix this issue?

[Caellian]

Not sure what to make of this yet. I'm pretty sure the same PRs referenced in #1930 are the cause, and I'd like to see whether fix for that will fix this, because it will affect this as well. I'm not sure why the images are affected though because I don't think I touched those.

I'll see whether changes I plan for fixing #1930 will fix this and I guess we'll go from there.

[ACR-Jeff]

Ok, I reverted back to the previous version for the time being.

[Caellian]

Can you try revert/dpi-changes branch and let me know whether this is fixed?

git clone -b revert/dpi-changes git@github.com:brndnmtthws/conky.git test_conky
cmake -S test_conky -B test_conky/build
cmake --build test_conky/build

# run with
./test_conky/build/src/conky <options>

[ACR-Jeff]

Can you try revert/dpi-changes branch and let me know whether this is fixed?

git clone -b revert/dpi-changes git@github.com:brndnmtthws/conky.git test_conky
cmake -S test_conky -B test_conky/build
cmake --build test_conky/build

# run with
./test_conky/build/src/conky <options>

I will have to get back to this in a bit, I do have a timeshift backup with version 1.21.1 that I can restore and test, I am at work at the moment.