brndnmtthws / conky

Light-weight system monitor for X, Wayland (sort of), and other things, too
https://conky.cc
GNU General Public License v3.0
7.31k stars 620 forks source link

Fix for the graph scale text colour changing depending on graph position #1957

Closed ghost closed 5 months ago

ghost commented 5 months ago

Checklist

Description

In the current latest code of conky, when you have a graph scale enabled, the text will change colour whenever a "high point" on the graph reached the "end" of the graph. It's difficult to describe so I took some screenshots:

Before

before-normal before-error

The scale text changes colour to whatever the colour of the leftmost "bar" of the graph is.

After

after-normal after-error

No longer does this

I'm not sure if this was an intended feature, if it was, feel free to close this. imo it shouldn't change colour because it makes the text very hard to read when the whole graph is full of red. It's a simple fix, just adding one extra line to change the colour back to the "first" graph colour (i.e. the colour of the lowest values)

There shouldn't be any unintended side effects of the change, because looking at the code, this is the last if statement in a block, and right after the if statements, the colour gets changed anyway (set_foreground_color(last_colour);)

netlify[bot] commented 5 months ago

Deploy Preview for conkyweb canceled.

Name Link
Latest commit 776f3d64bccbbf9c6c6f0ab4ad0a1ec6d1f11964
Latest deploy log https://app.netlify.com/sites/conkyweb/deploys/665f31c498d3bd000887a46e
ghost commented 5 months ago

Not sure what the Docker issue is, I don't have any experience with Docker.