search

brndnmtthws / optimal-buy-cbpro

Scheduled buying of BTC, ETH, and LTC from Coinbase Pro, optimally!
The Unlicense
333 stars 68 forks source link

size is too accurate issue #32

Open datawithdev opened 4 years ago

datawithdev commented 4 years ago

some orders are placed for smaller units than supported by the exchange. for example Ripple (XRP)

image

markspivey commented 3 years ago

Any suggestions on this @brndnmtthws? I would love to add MATIC to my ongoing buys but I am suffering with the same issue.

It looks like CBPro support "base_increment" and "quote_increment" which might alleviate the issue.

Is there even a long-term possibility of integrating this with the CCXT (CryptoCurrency eXchange Trading Library)? That would potentially allow support for a greater number of exchanges.

brndnmtthws commented 3 years ago

The API support is there, yes. I'm not a huge fan of supporting all these random shitcoins but I am also a very dumb person who doesn't know how to pick winners and losers, so I won't gatekeep any pump and dump schemes.

I'll take a look and get back to you, but I've got a ton of crap on my plate so don't expect a quick turnaround.

i-am-coolbeans commented 3 years ago

Hello sir, thank you very much for creating this project for everyone to use. I encountered this issue as well when adding ADA as a parameter. I understand you are busy, just wanted to share my interest in this project and hope there is a possibility to add some logic to reduce the decimals for the cheaper coins so that orders execute. Thank you again for your contribution.

wbernier8 commented 3 years ago

Is there even a long-term possibility of integrating this with the CCXT (CryptoCurrency eXchange Trading Library)? That would potentially allow support for a greater number of exchanges.

I attempted this with my fork. optimal-buy-ccxt But it is currently only working with Gemini. I am not a professional coder but feel free to contribute.

markspivey commented 2 months ago

@brndnmtthws even after all this time I still feel there's value here, so I completely reworked the project to work with Coinbase's current APIs, to resolve the 'size too accurate' problem, and to support more coins. Is there any chance you would mind helping with a code review?

brndnmtthws commented 2 months ago

@brndnmtthws even after all this time I still feel there's value here, so I completely reworked the project to work with Coinbase's current APIs, to resolve the 'size too accurate' problem, and to support more coins. Is there any chance you would mind helping with a code review?

If you open a PR I'd be happy to look at it. However, if it's a huge change, you are more than welcome to just fork it and make it your own. I don't really use this anymore, but I'm happy to review code.