broadinstitute / ABC-Enhancer-Gene-Prediction

Cell type specific enhancer-gene predictions using ABC model (Fulco, Nasser et al, Nature Genetics 2019)
MIT License
203 stars 62 forks source link

can list of genes in the reference be the list of differential genes only? #212

Closed olechnwin closed 6 months ago

olechnwin commented 7 months ago

Hi,

I have a question. In the reference files input for ABC model, can the list of genes be the differential genes only? I wonder if this is acceptable or if it biased the model somehow and should not be done.

Thank you in advance for your clarification!

atancoder commented 6 months ago

See Jesse’s response below

engreitz commented 6 months ago

You should include all genes in the ABC calculation (using our provided promoter file), and then filter later.

This is because the list of genes (esp. the list of promoters) affects which peaks are included in the initial calculation, which ends up affecting the scores. If you run using only the list of promoters that are differential, the absolute values of the scores will be different than what the model expects

On Tue, Apr 23, 2024 at 11:58 AM Anthony Tan @.***> wrote:

i think that would be fine as ABC scores would be normalized on a per gene basis anyways.

— Reply to this email directly, view it on GitHub https://github.com/broadinstitute/ABC-Enhancer-Gene-Prediction/issues/212#issuecomment-2073203253, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA3LGEBX6EUFQK6KALEQFMLY62VMBAVCNFSM6AAAAABFOOE3Q6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZTGIYDGMRVGM . You are receiving this because you are subscribed to this thread.Message ID: <broadinstitute/ABC-Enhancer-Gene-Prediction/issues/212/2073203253@ github.com>

-- Jesse Engreitz, PhD Assistant Professor, Department of Genetics BASE Research Initiative, Betty Irene Moore Children’s Heart Center Stanford University School of Medicine www.engreitzlab.org +1 (206) 310-3935 Pronouns: He/him/his

olechnwin commented 6 months ago

Thank you so much for your insights!