broadinstitute / HydrantFC

Repository for the FireCloud version of Hydrant (currently in alpha testing)
BSD 3-Clause "New" or "Revised" License
5 stars 0 forks source link

test command should validate JSON prior to executing cromwell #20

Closed noblem closed 6 years ago

noblem commented 6 years ago

It is very easy to write a bad inputs.json file, and have to iterate multiple times to correct it. In the current implementation each iteration invokes cromwell that is guaranteed to fail, creating multiple log files, directory subtrees etc.

All of that guaranteed failure can be avoided if, instead of passing a bad JSON to cromwell for execution, the test command did a preliminary validation of syntax. Something as simple as a try block around json.load(open("tests/inputs.json")) would suffice.

noblem commented 6 years ago

See #21

noblem commented 6 years ago

Fixed in https://github.com/broadinstitute/HydrantFC/commit/0bc4db839a4d68591dbf572296c22598f5cae610