broadinstitute / adapt

A package for designing activity-informed nucleic acid diagnostics for viruses.
MIT License
27 stars 1 forks source link

Add unaligned FASTA input type #58

Closed priyappillai closed 2 years ago

priyappillai commented 2 years ago

In design.py:

In prepare_alignment.py:

codecov[bot] commented 2 years ago

Codecov Report

Merging #58 (c09f397) into main (524cadc) will increase coverage by 0.32%. The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
+ Coverage   84.83%   85.15%   +0.32%     
==========================================
  Files          48       48              
  Lines        7543     7599      +56     
==========================================
+ Hits         6399     6471      +72     
+ Misses       1144     1128      -16     
Impacted Files Coverage Δ
bin/design.py 65.81% <50.00%> (+1.59%) :arrow_up:
adapt/prepare/prepare_alignment.py 63.63% <83.33%> (+9.03%) :arrow_up:
bin/tests/test_design.py 99.51% <100.00%> (+1.16%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 524cadc...c09f397. Read the comment docs.

priyappillai commented 2 years ago

On the Codecov report-I don't think all of the differences are super necessary to be tested? I can at least add basic tests for the unaligned fasta input type to our integration tests. Also can modify Codecov to just comment and not do the "check".