broadinstitute / adapt

A package for designing activity-informed nucleic acid diagnostics for viruses.
MIT License
27 stars 1 forks source link

Modify expected activity per guide to only use sequences where the guide is the best of the set #60

Closed priyappillai closed 2 years ago

priyappillai commented 2 years ago

Only use sequences where the guide is the best of the guide set when calculating expected activity. If sequence ties against multiple guides, it will be counted for all of them.

Details

In guide_search.py

In target_search.py

codecov[bot] commented 2 years ago

Codecov Report

Merging #60 (1a6ff00) into main (a96ce8d) will decrease coverage by 0.01%. The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             main      #60      +/-   ##
==========================================
- Coverage   85.15%   85.14%   -0.02%     
==========================================
  Files          48       48              
  Lines        7599     7647      +48     
==========================================
+ Hits         6471     6511      +40     
- Misses       1128     1136       +8     
Impacted Files Coverage Δ
adapt/target_search.py 77.52% <0.00%> (-0.26%) :arrow_down:
adapt/guide_search.py 84.71% <76.66%> (-0.43%) :arrow_down:
adapt/tests/test_guide_search.py 99.35% <100.00%> (+0.02%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a96ce8d...1a6ff00. Read the comment docs.