broadinstitute / adapt

A package for designing activity-informed nucleic acid diagnostics for viruses.
MIT License
27 stars 1 forks source link

Improve hash function in MinHash family #69

Closed haydenm closed 1 year ago

haydenm commented 1 year ago

This PR makes several small changes designed to improve the behavior of the MinHash family's hash functions:

It is based on PR #45 in the CATCH repository.

codecov[bot] commented 1 year ago

Codecov Report

Base: 87.29% // Head: 87.32% // Increases project coverage by +0.02% :tada:

Coverage data is based on head (c85d1d6) compared to base (c108e7d). Patch coverage: 91.89% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #69 +/- ## ========================================== + Coverage 87.29% 87.32% +0.02% ========================================== Files 56 56 Lines 9771 9798 +27 ========================================== + Hits 8530 8556 +26 - Misses 1241 1242 +1 ``` | [Impacted Files](https://codecov.io/gh/broadinstitute/adapt/pull/69?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=broadinstitute) | Coverage Δ | | |---|---|---| | [adapt/utils/lsh.py](https://codecov.io/gh/broadinstitute/adapt/pull/69/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=broadinstitute#diff-YWRhcHQvdXRpbHMvbHNoLnB5) | `97.53% <85.00%> (-0.50%)` | :arrow_down: | | [adapt/utils/tests/test\_lsh.py](https://codecov.io/gh/broadinstitute/adapt/pull/69/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=broadinstitute#diff-YWRhcHQvdXRpbHMvdGVzdHMvdGVzdF9sc2gucHk=) | `98.30% <100.00%> (+0.10%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=broadinstitute). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=broadinstitute)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.