broadinstitute / cellpainting-gallery

Cell Painting Gallery
https://broadinstitute.github.io/cellpainting-gallery/
MIT License
58 stars 11 forks source link

Write README for cellpainting-gallery GitHub repo #9

Closed shntnu closed 2 years ago

shntnu commented 2 years ago

Update: I've moved this Q to https://github.com/jump-cellpainting/aws/issues/62#issuecomment-1159580088; let's discuss it there.

Once this PR is merged, we can tag Erin Chu in https://github.com/awslabs/open-data-registry/pull/1003#event-6834149376 to review that PR.

Erin Chu has already merged that PR 🎉


@ErinWeisbart

I made some edits, mostly cleanup and adding some citations.

What do you think of splitting out jump-pilot/source_4 – which comprises all the jump-pilots from Broad - into two parts (or maybe 3 parts):

That has two advantages

ErinWeisbart commented 2 years ago

I updated README with jump-pilots split as per discussion above.

We still need:

shntnu commented 2 years ago

Thanks, @ErinWeisbart – now fixed. Have a look a feel free to merge

ErinWeisbart commented 2 years ago

You've written the cell type as U2-OS. I'm changing it to U2OS as I think that's more commonly used (and then U-2 OS and then U2-OS FWIW), if that's okay?

One final question - for citation, it currently just tells users to cite the initial publication of whatever dataset they use. Do we also want to ask users to cite the gallery on RODA?

shntnu commented 2 years ago

You've written the cell type as U2-OS. I'm changing it to U2OS as I think that's more commonly used (and then U-2 OS and then U2-OS FWIW), if that's okay?

Perfect

One final question - for citation, it currently just tells users to cite the initial publication of whatever dataset they use. Do we also want to ask users to cite the gallery on RODA?

So glad you pointed this out! Now added