broadinstitute / cromshell

CLI for interacting with Cromwell servers
BSD 3-Clause "New" or "Revised" License
53 stars 15 forks source link

Request to add a command to validate WDLs through cromshell. #261

Closed bshifaw closed 1 year ago

bshifaw commented 1 year ago

Problem:

Request: Add a wrapper command for miniwdl to validate WDLs through cromshell.

cromshell validate helloworld.wdl

jamesemery commented 1 year ago

👍 @bshifaw would it be possible to make the behavior for Cromshell2 to run Womtool validate before submitting your job at all? This was a feature of the old Cromshell and it saves a lot of time and energy having to wait for the server to progress your job past "submitted" to know that you added a silly typo to your script.

bshifaw commented 1 year ago

👍 @bshifaw would it be possible to make the behavior for Cromshell2 to run Womtool validate before submitting your job at all? This was a feature of the old Cromshell and it saves a lot of time and energy having to wait for the server to progress your job past "submitted" to know that you added a silly typo to your script.

Great question @jamesemery! Cromshell does end up validating before submitting to cromshell. Previously it would perform it locally which required a local installation of womtool but has shifted to using the Cromwell server womtool API (https://github.com/broadinstitute/cromshell/commit/4372e0321aa002ab0ba7db9e2d5aab3f24249a88). This avoids requiring the user from installing womtool on their end. This validation "should" be close to or just as fast as validating locally but let us know if you find it slower.