search

broadinstitute / cromwell-tools

A collection of Python clients and accessory scripts for interacting with the Cromwell
https://cromwell-tools.readthedocs.io
BSD 3-Clause "New" or "Revised" License
22 stars 9 forks source link

[Bug] jes_gcs_root is always default #109

Open morganecf opened 1 year ago

morganecf commented 1 year ago

If using a service account key credentials file, the CromwellAPI.submit function ignores the existing jes_gcs_root attribute in the user-supplied options file. When compose_oauth_options_for_jes_backend_cromwell is called here, no execution_bucket is passed in to override the default of None.

https://github.com/broadinstitute/cromwell-tools/blob/fb1753dd0fb5363c86c591a5728efef52fc3661a/cromwell_tools/utilities.py#L377-L381

jes_gcs_root then automatically defaults to the gs://%s-cromwell-execution/caas-cromwell-executions bucket each time (as long as you're using a service account key):

https://github.com/broadinstitute/cromwell-tools/blob/fb1753dd0fb5363c86c591a5728efef52fc3661a/cromwell_tools/utilities.py#L407-L415

rexwangcc commented 1 year ago

Hey Morg, thanks for reporting the issue! I'm glad to take a look at it sometime later but since I'm no longer officially working at the Broad, I have no access to either triage the issue or updating settings of this repo; without a testing Cromwell testing environment, I'm not sure how much I can do with the above issues, I'm happy to talk more about it if it blocks your current work; and if it's pretty urgent, I suggest you look for help from internal DSP folks, thanks!