Closed ambrosejcarr closed 6 years ago
@ambrosejcarr This looks good to me! For the major questions:
_localize_file
is necessary for this validation use case.Some possible choices for 2 would be:
Of the options, I like (2, docker) the best. On one hand I don't like adding docker dependencies, but if people are using cromwell
, I think it's safe to assume they're at least comfortable learning about containers.
(3) will make the tests take much longer, while (1) could potentially cause us a lot of egress charges if people start using this repo or we run a lot of tests.
What do you think?
Yeah, I think (2) docker would be the best among all of the 3 options, whereas requires a little bit more refactoring to your current code. Besides, I'm open to any other alternatives.
We use git-lfs in gatk to store large binaries in git. It works well but adds some hassle.
Comments addressed, but depends on #28 to get the tests to pass on travis.
Ok, this one's ready to be re-reviewed. I kinda mangled the docker a bit. Would love it if this generated some conversation about #26
PR Summary
This is a work-in-progress PR that enables
cromwell-tools
to triggerwomtool validate
by localizing thewdl
and all listed tasks independencies.json
to a temporary directory and callingwomtool validate
from that directory.I also optimized the imports (
stdlib > external libs > cromwell_tools
)Major questions for this work-in-progress:
localize
method that uses thedownload_http
method forhttp
files.PR Checklist: