Fix a bug that prevents submitting a zipped file as dependency. - Githubissues

broadinstitute / cromwell-tools

A collection of Python clients and accessory scripts for interacting with the Cromwell

https://cromwell-tools.readthedocs.io

BSD 3-Clause "New" or "Revised" License

22 stars 9 forks source link

Fix a bug that prevents submitting a zipped file as dependency. #61

Closed rexwangcc closed 5 years ago

rexwangcc commented 5 years ago

Purpose

Please explain the purpose of this PR and include links to any GitHub issues that it fixes:

https://github.com/HumanCellAtlas/secondary-analysis/issues/541

Changes

Please list out what major changes were made in this PR to address the issue:
Fix the bug with the conditions.

Review Instructions

Please provide instructions about how should a reviewer test/to verify the changes in this PR:
Please review the update conditional logic.

PR Checklist

Please ensure the following when opening a PR:

[ ] This PR added or updated tests.
[ ] This PR updated docstrings or documentation.
[ ] This PR applied Python style guidelines, specifically followed Google style docstrings for this repo.
[ ] This PR considered generalizability beyond our own use case.

Follow-up Discussions

Please append follow-up discussions and issues during the review process below:

No follow-up discussions.

rexwangcc commented 5 years ago

@samanehsan I added the unit test cases, could you take another look? 🎁