search

broadinstitute / cromwell

Scientific workflow engine designed for simplicity & scalability. Trivially transition between one off use cases to massive scale production environments
http://cromwell.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
997 stars 361 forks source link

Don't issue "backend doesn't support backend" messages #1997

Open cjllanwarne opened 7 years ago

cjllanwarne commented 7 years ago

The local backend shouldn't be checking the "backend" attribute.

Probably ties in with the "runtime attributes aren't great" epic.

Impact: low Probability: low (until people start doing multi-backend WDLs)

cjllanwarne commented 7 years ago

e.g.

2017-02-16 14:08:52,527 cromwell-system-akka.dispatchers.backend-dispatcher-31 WARN  - Local [UUID(d343a700)]: Key/s [backend] is/are not supported by backend. Unsupported attributes will not be part of job executions.
delocalizer commented 7 years ago

For the record, we use a custom backend that we specify as default, and specify local for some tasks with

runtime {
  backend: "Local"
}

and I've noticed those WARN messages in the logs but wasn't really concerned as everything works ok.

katevoss commented 7 years ago

As a user, I want Cromwell to not check the backend attribute, so that I can not be distracted by strange warnings that aren't actually useful.

EvanTheB commented 6 years ago

+1 The runtime.backend parameter is completely undocumented from what I can tell, but mentioned variously in forums and here on github. I tried to use it, saw the error, got extremely confused, and here I am hours later.

natechols commented 5 years ago

+1 I spent an hour digging in the code to try to understand why this happens, but no luck.