broadinstitute / cromwell

Scientific workflow engine designed for simplicity & scalability. Trivially transition between one off use cases to massive scale production environments
http://cromwell.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
995 stars 360 forks source link

Support for WDL 1.1 #6221

Open Coppini opened 3 years ago

Coppini commented 3 years ago

I tried running a WDL in version 1.1, to use the as_map(Array[Pair[X,Y]]) function, but it doesn't work.

  "failures": [
    {
      "causedBy": [
        {
          "causedBy": [

          ],
          "message": "ERROR: Finished parsing without consuming all tokens.\n\nversion 1.1\n^\n     "
        }
      ],
      "message": "Workflow input processing failed"
    }
  ],

According to the LanguageSupport specifications, the only supported versions for WDL are 1.0 and development. Is this correct?

Would it be possible to add support for WDL 1.1?

Jira issue

skchronicles commented 3 years ago

@pshapiro4broad Is there any update on this or planned inclusion? I am also running into the same issue. It would be nice if Cromwell supported the latest specification(s) of WDL.

beukueb commented 2 years ago

I ran into the same issue now. If the development version is currently wdl and as specified in the cromwell documentation "As the SPEC is being improved and honed, Cromwell continues to support the current development version of WDL. That means that when (or shortly after) new versions are published, Cromwell will be ready to support them." Could you take a snapshot of the current development version and name it wdl 1.1? This would offer some stability for developers who rely on current additions to the spec.

Melkaz commented 2 years ago

Any update about WDL 1.1 support ?

samuelejones commented 2 years ago

I have also been running into issues regarding syntax and have just realised that Cromwell doesn't support the WDL 1.1 spec. Any news on whether this is something that will be implemented soon? It has been over a year since the spec was introduced and it introduces features sorely lacking in 1.0...!

pieterlukasse commented 2 years ago

any updates?

adamnovak commented 1 year ago

This is causing a problem for me trying to write a workflow. I want to use string interpolation, which is a WDL 1.1 feature. It is not specified as being available in WDL 1.0 outside of commands, but Cromwell happens to support it in all strings in 1.0 (and maybe also draft-2?).

If I put a version 1.1 statement in my workflow, Cromwell won't parse it, because it knows it doesn't support 1.1. But if I put a version 1.0 statement, my workflow isn't actually compliant with the spec, because 1.0 doesn't say that this feature is available.

So I have a workflow that both Cromwell and any 1.1-compliant runner can run, except I can't write a correct version statement for it, or Cromwell will reject it.

One solution might be to tell Cromwell that it does support version 1.1, at least partially, instead of rejecting all 1.1 workflows.

notestaff commented 8 months ago

Are there near-term plans for cromwell to support WDL 1.1? Thanks!

aednichols commented 8 months ago

Yes, WDL 1.1 is currently being developed.