broadinstitute / dsp-data-models

Data model definitions + Jade schemas for the DSP Core Model & Monster-specific extensions
BSD 3-Clause "New" or "Revised" License
1 stars 0 forks source link

ClinVar Phase 1 #14

Closed toneillbroad closed 5 years ago

toneillbroad commented 5 years ago

Tables, assets and generated Jade schema for review.

toneillbroad commented 5 years ago

Dan, regarding your proposal of moving the links field from the primary id of the from table to the foreign key field of the to table, I'm ok with that, but that changes the nature of the field from a links json array to a singular link object containing table_name and column_name correct? Are you suggesting that if all primary key fields are named id that the new link object on the foreign key would simply contain table_name? My vote would be for the former vs. the latter.