search

broadinstitute / firecloud_developer_toolkit

Utilities to help algorithm developers dockerize new tasks, debug them, and put them into Firecloud.
BSD 3-Clause "New" or "Revised" License
2 stars 0 forks source link

crom - wdl should be more tightly bound to container and git version #38

Open gsaksena opened 7 years ago

gsaksena commented 7 years ago

Ideally, in the process of pushing to dockerhub and firecloud, the wdl would be updated and re-checked in with the github version number, using a string replacement like sccs had. This is impossible, because the git version number is a hash.

Perhaps what would work would be to first ensure the docker image build is current, then auto-edit the wdl to refer to it via the image's hash. This hash is then pushed as the docker name (or version), and FC refers to the image just by the hash, rather than some other label. (Is this solid, or would dockerhub just treat the hash as any other mutable label?)

gsaksena commented 7 years ago

GDAC uses valcon, and tags the container with the github hash.

Another approach is to do magic during docker push: redo the docker build to ensure it is current, update the wdl with the docker build hash, commit/push this wdl, before letting the docker get pushed to the repo. such tagged wdl's would need to also be pushed to reference the new docker.

Another approach is to let the docker hosting site do the build direct from Github.