broadinstitute / gamgee

A C++14 library for NGS data formats
http://broadinstitute.github.io/gamgee/
MIT License
40 stars 13 forks source link

Verify correctness of merge_variant_headers() in variant_utils after htslib rebase #363

Closed droazen closed 10 years ago

droazen commented 10 years ago

There was some question raised during code review about whether merge_variant_headers() in variant_utils is still correct given the recent changes to the way htslib syncs changes to variant headers (although tests do pass). In particular, we need to figure out whether we still need to pass in a null pointer at the end to bcf_hdr_add_sample().