search

broadinstitute / gamgee

A C++14 library for NGS data formats
http://broadinstitute.github.io/gamgee/
MIT License
40 stars 13 forks source link

Remove obsolete call in merge_variant_headers() #364

Closed droazen closed 9 years ago

droazen commented 9 years ago

Now that htslib expects us to sync headers manually, we don't need to pass in a nullptr when we're done adding samples to a header

Resolves #363

droazen commented 9 years ago

For @jmthibault79 to review please

coveralls commented 9 years ago

Coverage Status

Coverage increased (+10.36%) when pulling 52011aff7d0f206ab15416dab18d8f0e7ad047b4 on dr_remove_obsolete_call_in_merge_variant_headers into e55dbd82b2aea9a018a97f511bccde93eb325fa5 on master.

jmthibault79 commented 9 years ago

:+1:

droazen commented 9 years ago

I love how coveralls claims that coverage has increased 10% as a result of this patch -- it is so messed up since the move to cmake