Change m_pending_variants to a vector

broadinstitute / gamgee

A C++14 library for NGS data formats

http://broadinstitute.github.io/gamgee/

MIT License

40 stars 13 forks source link

Change m_pending_variants to a vector #367

Closed jmthibault79 closed 10 years ago

jmthibault79 commented 10 years ago

Fixes #358

coveralls commented 10 years ago

Coverage increased (+1.95%) when pulling e1182b2cb6499fcce070c321e38b2a7fe8f07381 on jt_pending_vector into b6bdb1c6504791e3ea81e45242d55bbc55719d5a on master.

coveralls commented 10 years ago

Coverage decreased (-5.24%) when pulling 86d960cff4f1220da715616395d0375d38d2f128 on jt_pending_vector into b6bdb1c6504791e3ea81e45242d55bbc55719d5a on master.

droazen commented 10 years ago

Approach of doing in-place moves within the vector then calling resize() seems sound -- feel free to rebase and merge this. We should benchmark this change with a large number of samples to see what effect it has, though.

coveralls commented 10 years ago

Coverage decreased (-5.24%) when pulling 5d6305247e6daa73d3cd6aea3bc3ffa76d2c0a26 on jt_pending_vector into b6bdb1c6504791e3ea81e45242d55bbc55719d5a on master.