Made return values for variant field iterators consistent with STL iterators

broadinstitute / gamgee

A C++14 library for NGS data formats

http://broadinstitute.github.io/gamgee/

MIT License

40 stars 13 forks source link

Made return values for variant field iterators consistent with STL iterators #375

Closed kgururaj closed 10 years ago

kgururaj commented 10 years ago

Fixed post and pre increment/decrement operations for SharedFieldIterator, IndividualFieldIterator and IndividualFieldValueIterator a. Post inc/dec always return a copy of the iterator with the original position of this iterator (before the inc/dec) b. Pre inc/dec return reference to this iterator
Added some simple test cases for inc/dec

PS: @droazen will love the fact that one more test function was added to variant_reader_test.cpp

coveralls commented 10 years ago

Coverage decreased (-1.98%) when pulling 016343da72c1a683f27cb74218aac95cc4ed908b on intel_iterator_inc_dec into 036af7078adb5625b9ea7ef072ca5da9c1d07920 on master.

droazen commented 10 years ago

:+1: Looks good -- will merge. This resolves https://github.com/broadinstitute/gamgee/issues/318, right?