broadinstitute / gamgee

A C++14 library for NGS data formats

http://broadinstitute.github.io/gamgee/

MIT License

40 stars 13 forks source link

SyncedVariantIterator now outputs "sparse" Variant vectors #379

Closed jmthibault79 closed 10 years ago

jmthibault79 commented 10 years ago

Depends on #377 - will rebase after that is merged

coveralls commented 10 years ago

Coverage increased (+8.87%) when pulling c3b1922f2124e95fe4114146ed6a7510c07ff79c on jt_sparse_SVI into 05676cf5909257068ca8cdc5cdb26d61cc60d5b5 on master.

droazen commented 10 years ago

377 is merged -- please rebase and I'll be happy to review

jmthibault79 commented 10 years ago

Done, thanks

coveralls commented 10 years ago

Coverage increased (+0.0%) when pulling 068d436fd264e7b04eb599f5b0f023ffc88c79e3 on jt_sparse_SVI into 71009ce6ef8c6db9640dc05830b049e88b2d63a1 on master.

droazen commented 10 years ago

Review complete -- one performance question, and one safety question to address

coveralls commented 10 years ago

Coverage remained the same when pulling de2c0b7eb1db43aae9410e8c89be3e4f8f130332 on jt_sparse_SVI into 03abf4b25e02cdaeb930bfa3eae6832a898d88a0 on master.