search

broadinstitute / gamgee

A C++14 library for NGS data formats
http://broadinstitute.github.io/gamgee/
MIT License
40 stars 13 forks source link

Encode genotypes automatically in VariantBuilder instead of requiring the client to call Genotype::encode_genotype() #383

Closed droazen closed 9 years ago

droazen commented 9 years ago

-VariantBuilder genotype setters now call appropriate Genotype::encode_genotype() function for you.

-Updated tests/documentation accordingly.

-Added some additional move semantics to per-sample genotype setters to allow clients to avoid extra copies when they don't need to re-use their genotype data.

-Added disclaimers to Genotype::encode_genotype() functions that they should only be called directly if you are working with low-level BCF data, and not when using VariantBuilder.

-Specifying phasing is still an issue, but will be addressed separately in #373

Resolves #371

coveralls commented 9 years ago

Coverage Status

Coverage decreased (-6.47%) when pulling 65378293f5d1553fdad195204455d05c4b9c7f33 on dr_vb_auto_encode_genotypes into f53b18e39459ecdaffda8a8aade931dcef8ccf2c on master.

jmthibault79 commented 9 years ago

Looks great. I have no comments. :+1: