broadinstitute / gamgee

A C++14 library for NGS data formats
http://broadinstitute.github.io/gamgee/
MIT License
40 stars 13 forks source link

File iterator increment operators should be consistent with STL #386

Open jmthibault79 opened 9 years ago

jmthibault79 commented 9 years ago

Specifically, preincrement operators should return a reference to the iterator, not the value. Where applicable (copyable), postincrement operators should return a copy of the iterator before the increment operation.

Inspired by #375

kgururaj commented 9 years ago

Same for decrement operator also

jmthibault79 commented 9 years ago

Yes, if we have any decrements. But we don't in the file iterators. I'll update the ticket name to clarify that I only mean those iterators.