Declaration of move ctor make is sufficient

broadinstitute / gamgee

A C++14 library for NGS data formats

http://broadinstitute.github.io/gamgee/

MIT License

40 stars 13 forks source link

Declaration of move ctor make is sufficient #403

Closed cppfool closed 9 years ago

cppfool commented 9 years ago

In C++14 declaration of Genotype's move ctor, Genotype(Genotype&&), renders Genotype's copy constructor and copy assignment operator deleted. We needn't do that.

cppfool commented 9 years ago

Correction: Declaration of move ctor is sufficient #403

make was extra word there.

jmthibault79 commented 9 years ago

Hello and thank you for the contribution! Unfortunately, gamgee is no longer under active development.

Regarding this change specifically, our standard is to explicitly specify all ctors. See the discussion at #131 for more information.