search

broadinstitute / gdctools

Python and UNIX CLI utilities to simplify interaction with the NIH/NCI Genomics Data Commons
Other
31 stars 4 forks source link

create_loadfile and matplotlib dependency #3

Closed noblem closed 8 years ago

noblem commented 8 years ago

I'd bet that this is already on your list, Tim, so this is just a reminder so that we don't forget when prepping for release: reports generation should in principle be generated from counts and/or loadfiles, by a distinct process invoked after loadfile generation ... rather than by function call within the same process. I think this is what sample_report.py embodies, but there's some (perhaps leftover) code in create_loadfile which imports report.py, which in turn also imports matplotlib ... and immediately breaks on my virginal homebrew-ed Python setup.

noblem commented 8 years ago

This was easy to resolve, so I did.