search

broadinstitute / genetic-prevalence-estimator

https://genie.broadinstitute.org/
BSD 3-Clause "New" or "Revised" License
1 stars 0 forks source link

Source checkbox option remains after list converted from recommended to custom #144

Open sambaxter opened 1 year ago

sambaxter commented 1 year ago

If you create a list using the recommended functionality, but then later add variants manually the "compare by source" check box remains and they are all assigned as gnomAD. If possible the "compare by source" option should be disabled once the list is converted to manual.

image
nawatts commented 1 year ago

🤔 Starting with #111 and continuing with adding variants to lists, we've really blurred the line between "Recommended" and "Custom" variant lists. So much so that aall "Recommended" vs "Custom" really means now is what was originally selected in the create variant list form.

Would it make sense to extend the "Compare by source" graph to include the "Custom" source as well as ClinVar and gnomAD?

sambaxter commented 11 months ago

Just coming back to this as I review tickets. Is it possible to still know what the source is even if the list is custom? The logic is if it has been seen in ClinVar then it would be marked as ClinVar and if not in ClinVar we would default to gnomAD. Would that work?