Add frontend CI - Githubissues

broadinstitute / genetic-prevalence-estimator

https://genie.broadinstitute.org/

BSD 3-Clause "New" or "Revised" License

1 stars 0 forks source link

Add frontend CI #151

Closed rileyhgrant closed 1 year ago

rileyhgrant commented 1 year ago

Adds CI via GitHub Actions to the frontend of the repository.

On pull request open and merge into main, the CI:

Verifies clean build
- Typechecks
- Lints
Runs Jest tests

Todo:

[x] Consider adding eslintrc file for more configurable js linting
- sticking with the create-react-apps intial eslint reference file for now
[ ] Add Jest snapshot tests for existing components for the frontend
[x] Stick with npm ~~Migrate from npm -> yarn~~

nawatts commented 1 year ago

Also, I see in the todo list in the PR description:

Migrate from npm -> yarn

What's the motivation to switch from npm to yarn?

rileyhgrant commented 1 year ago

Hiya Nick, wow thanks for being on top of looking at this PR. I had unmarked it as a draft to let the CI actually run.

I'll make those changes you requested, thanks for the guidance and info, it's much appreciated.

As for motivation of npm -> yarn, honestly it's just that I like yarn a bit better of the two (though I suppose I haven't used either extensively), which is perhaps a bad reason to change it now. I can scratch that one off the list.