broadinstitute / genetic-prevalence-estimator

https://genie.broadinstitute.org/
BSD 3-Clause "New" or "Revised" License
1 stars 0 forks source link

Display "n" of contributing variants for each ancestry #164

Open sambaxter opened 1 year ago

sambaxter commented 1 year ago

Above where users can select "compare contributions by source" please add another toggle that says "show number of variants contributing to carrier frequency" When they select this toggle, the number of variants in the list that have an AF>0 in a given population/genetic ancestry group will be displayed on the graph and add a column to the table adds that number to the chart as well (same as the table splits for the compare by source). Title for this column will be # of variants.

If someone also select "compare contributions by source" then maybe we can still display the numbers inside the colors, or if one color is too small just display them over each bar, color coded red or purple. If this is too hard we can make it one or the other, or just add them to the table and not the graph.

image
rileyhgrant commented 1 month ago

Currently, we remove this information as we calculate (i.e., we just sum then divide to get the denominator, not caring about how many samples get included in the denominator).

We should be careful about how we implement this, to be sure that any list that does not have this information the first time it's loaded does not cause a crash, and correctly generates then saves this information.