search

broadinstitute / genetic-prevalence-estimator

https://genie.broadinstitute.org/
BSD 3-Clause "New" or "Revised" License
1 stars 0 forks source link

Sort variants table by allele frequency #62

Closed nawatts closed 2 years ago

nawatts commented 3 years ago

To highlight the variants that contribute the most to carrier frequency / prevalence (those with the highest allele frequency).

sambaxter commented 2 years ago

Sorting button is hidden inside the "allele frequency" header - I tried resizing my screen and that didn't fix it. Screen shot is attached.

image
nawatts commented 2 years ago

What browser are you using? Here's what I see:

Screen Shot 2022-04-11 at 11 10 28 AM

Admittedly though, the way I styled the arrow is a bit hacky.

https://github.com/broadinstitute/aggregate-frequency-calculator/blob/503921fcd32f5ae16b3cbcb1da5b31f1f1394771/frontend/src/components/VariantListPage/VariantsTable.tsx#L461-L467

sambaxter commented 2 years ago

I see it on both chrome and firefox

nawatts commented 2 years ago

Ah, this happens when the table is sorted by the last column. I was looking at a recommended variant list, where allele frequency is not the last column. Should be fixed by https://github.com/broadinstitute/aggregate-frequency-calculator/commit/9100d4c0a917d09c1f543ca790589b0815caebc0.