broadinstitute / gnomad_methods

Hail helper functions for the gnomAD project and Translational Genomics Group
https://gnomad.broadinstitute.org
MIT License
89 stars 29 forks source link

Fix bug in `process_consequences` that was introduced when adding support for VEP without polyphen #710

Closed jkgoodrich closed 5 months ago

jkgoodrich commented 5 months ago

This adds the following fixes to the current process_consequences:

The updated function also has the following fixes to the original code (before the support for no polyphen was added):

Here are some tests showing the comparison of the original code, the current code, and the code in this PR

fixes_to_process_consequences_small.html.zip

jkgoodrich commented 5 months ago

Yeah, my next PR completely changes this function, but it will take more time to review, so just getting this in with minimal changes to fix the bug. These changes were my first round of changes to fix the function before I got completely confused by this and other functions in vep.py and completely rewrote it

mike-w-wilson commented 5 months ago

Thank you!