search

broadinstitute / grit-benchmark

Benchmarking a metric used to evaluate a perturbation strength
BSD 3-Clause "New" or "Revised" License
5 stars 5 forks source link

Add grit aggregation #30

Closed hillsbury closed 3 years ago

hillsbury commented 3 years ago

add grit-informed aggregation files + removed large file, ready for review @gwaygenomics

gwaybio commented 3 years ago

Wonderful! I'll take a look ASAP

Three immediate things I noticed:

  1. Please run black
  2. Please run jupyter nbconvert --to=script --FilesWriter.build_directory=scripts/nbconverted *.ipynb (it needs to be run inside the folder where the notebooks are) and add the nbconverted .py files.
  3. For the code you borrowed from Niranj - please add attribution.
gwaybio commented 3 years ago

@hillsbury - now that this is merged, remember the important next steps so that you can contribute your next PR:

git checkout main
git fetch upstream
git merge upstream/main
git push