Open HugoHakem opened 2 months ago
Few remarks on Jump_portrait in get_jump_image
[ ] Would be better if instead of broadcasting the error: "More than one site found", a suggestion of correction was given
[ ] Would be great to enable to pass a list of str instead of just a str.
[ ] all the parameters of get_jump_image are not ully explained:
example apply_correction vs apply_illum
compressed
staging
[ ] tqdm takes a lot of space: let's try something from here, or add a way to disable it.
Workflow 1 and workflow 2
[ ] parameter corrections is not consistently defined which I think is confusing:
corrections = ["Orig"] # Can also be "Illum"
correction = None # or "Illum"
WIP on #44
afermg
commented
1 month ago afermg
commented
1 month ago
Few remarks on Jump_portrait in get_jump_image
[ ] Would be better if instead of broadcasting the error: "More than one site found", a suggestion of correction was given
[ ] Would be great to enable to pass a list of str instead of just a str.
[ ] all the parameters of get_jump_image are not ully explained:
example apply_correction vs apply_illum
compressed
staging
[ ] tqdm takes a lot of space: let's try something from here, or add a way to disable it.
Workflow 1 and workflow 2
[ ] parameter corrections is not consistently defined which I think is confusing:
corrections = ["Orig"] # Can also be "Illum"
correction = None # or "Illum"