search

broadinstitute / oncotator

Other
67 stars 33 forks source link

Variant type field value of "SNP" should be "SNV" #152

Open alexramos opened 10 years ago

alexramos commented 10 years ago

A SNV is a private mutation while a SNP is a mutation that is shared amongst a population.

LeeTL1220 commented 10 years ago

@alexramos Even though this is true, this might be a bit much to take on right be before public release. Can we eliminate the "Public Release" tag on this issue?

akiezun commented 10 years ago

+1 seems like a triviality with possible risk of breaking existing downstream code. vote to postpone

On Wed, Jun 11, 2014 at 1:51 PM, Lee Lichtenstein notifications@github.com wrote:

@alexramos https://github.com/alexramos Even though this is true, this might be a bit much to take on right be before public release. Can we eliminate the "Public Release" tag on this issue?

— Reply to this email directly or view it on GitHub https://github.com/broadinstitute/oncotator/issues/152#issuecomment-45775815 .

LeeTL1220 commented 10 years ago

@alexramos @akiezun I vote to postpone and (maybe) have a doc page. Removing the Public Release tag