search

broadinstitute / oncotator

Other
67 stars 32 forks source link

Improving ONPCombiner's attribute merging #331

Closed lbergelson closed 9 years ago

lbergelson commented 9 years ago

Fixes #329 Attributes that all have the same value for a combined mutation will be output only once. If any values differ they will all be output int the order that the mutations were originally in.

lbergelson commented 9 years ago

@LeeTL1220 Could you run the unit tests on your computer? I don't have the Oncotator datasources on this computer since the HD had to be wiped.

LeeTL1220 commented 9 years ago

@lbergelson Running unit tests. No comments worth mentioning on the code changes.

LeeTL1220 commented 9 years ago

Tests pass on my local machine and on travis.